Skip to content

feat: create client.properties for use with kafka scripts #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 21, 2025
Merged

feat: create client.properties for use with kafka scripts #898

merged 13 commits into from
Oct 21, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 14, 2025

Description

Fixes stackabletech/issues#768

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 14, 2025
razvan added 8 commits October 17, 2025 11:02
@razvan
fix: loose ends and cleanups (#900)
6c2dfa7 
* group kerberos code together

* clean up bootstrap listener ports

* update metrics.py to actually test for the existence of metrics

* read jmx config from server.yaml instead of broker.yaml

* update docs

* update changelog
@razvan
add comment about the kerberos situation
7f7076e
@razvan
update docs to remove kcat references
5274346
@razvan
remove comments from client.properties
a097395
@razvan
Merge branch 'main' into issues/768
7792699
@razvan
fix topic creation
f5fd225
@razvan
remove kcat from upgrade test
048e3de
@razvan
update changelog
5ec69da
@razvan
Copy link
Member Author

razvan commented Oct 18, 2025

🟡 CI: https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/46/

The only test that failed is the smoke-kraft test. I could not reproduce it locally.

@razvan razvan marked this pull request as ready for review October 18, 2025 15:09
@razvan razvan requested a review from a team October 18, 2025 15:09
@maltesander maltesander self-requested a review October 20, 2025 14:33
This was referenced Oct 20, 2025
Merged
Merged
maltesander
maltesander requested changes Oct 21, 2025
View reviewed changes
@razvan razvan requested a review from maltesander October 21, 2025 10:11
@razvan razvan enabled auto-merge October 21, 2025 10:11
maltesander
maltesander approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 5b6a022 Oct 21, 2025
17 checks passed
@razvan razvan deleted the issues/768 branch October 21, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@razvan razvan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kafka: operator should create client.properties for CLI tools in the product container

2 participants

@razvan @maltesander